xiconfjs/Gladdy-TBC
1
0
Fork 0
Code Issues 36 Pull Requests 2 Packages Projects Releases 30 Wiki Activity

Fix support for ElvUI with TotemPlates #81

Closed
Flamanis wants to merge 1 commits from main into main
pull from: main
merge into: :main
Conversation 4 Commits 1 Files Changed 1
+30 -32
Flamanis commented 2023-09-27 22:33:03 +02:00 (Migrated from github.com)
Copy Link
Copy Source

ElvUI does not force show their nameplates anymore as it can cause blocked actions. So TotemPlates would perma hide any ElvUI nameplate that was attached to a totem until a reload. This causes erroneous bug reports in ElvUI support channels from Gladdy users.

This forces a call to show when the TotemPlate is removed.

ElvUI does not force show their nameplates anymore as it can cause blocked actions. So TotemPlates would perma hide any ElvUI nameplate that was attached to a totem until a reload. This causes erroneous bug reports in ElvUI support channels from Gladdy users. This forces a call to show when the TotemPlate is removed.
XiconQoo commented 2023-09-29 20:51:21 +02:00 (Migrated from github.com)
Copy Link
Copy Source

See https://github.com/XiconQoo/Gladdy-TBC/commit/c122e2405498bf1753aa464f25a1fe789ed07cef for latest fix. I modified your commit a bit using the function ToggleAddon. Thanks for this PR. Gonna close it now

See https://github.com/XiconQoo/Gladdy-TBC/commit/c122e2405498bf1753aa464f25a1fe789ed07cef for latest fix. I modified your commit a bit using the function `ToggleAddon`. Thanks for this PR. Gonna close it now
Flamanis commented 2023-09-29 21:23:34 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Awesome! I didn't put too much effort into this fix as I don't personally pvp, but there were quite a few reports in elvui about it so I cobbled something together and had some users test. Glad you did something you find better :)

Thanks for the update.

Awesome! I didn't put too much effort into this fix as I don't personally pvp, but there were quite a few reports in elvui about it so I cobbled something together and had some users test. Glad you did something you find better :) Thanks for the update.
Flamanis commented 2023-09-30 18:17:37 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Your change now causes issues with Plater users. It keeps the nameplate on screen after totemplates is over.

Your change now causes issues with Plater users. It keeps the nameplate on screen after totemplates is over.
XiconQoo commented 2023-09-30 20:50:25 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks again, just updated it.

Thanks again, just updated it.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
xiconfjs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiconfjs/Gladdy-TBC#81