xiconfjs/Gladdy-TBC
1
0
Fork 0
Code Issues 36 Pull Requests 2 Packages Projects Releases 30 Wiki Activity

DR Level Icon Text #15

Closed
ManneN1 wants to merge 2 commits from main into main
pull from: main
merge into: :main
Conversation 1 Commits 2 Files Changed 1
+3459 -12849
ManneN1 commented 2021-09-21 22:27:54 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Hello,

I was missing the functionality to see the DR immunity level on the DR tracker in Gladdy. The border color thing does not do it for me.

This functionality exists in all (?) other DR trackers / Arena unitframe AddOns - so I added it. 1/2, 1/4 and ø for full immunity.

Don't hesitate to contact me if there are any questions.

Hello, I was missing the functionality to see the DR immunity level on the DR tracker in Gladdy. The border color thing does not do it for me. This functionality exists in all (?) other DR trackers / Arena unitframe AddOns - so I added it. 1/2, 1/4 and ø for full immunity. Don't hesitate to contact me if there are any questions.
XiconQoo commented 2021-09-27 13:27:46 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Thank you for contributing =)

I tested it and I will add this PR to my develop-branch and reject the PR here, as it messes with my GitFlow.

My develop branch is a private git repo. This way I can easily release hotfixes and still have a working develop environment.

Apreciated =)

Thank you for contributing =) I tested it and I will add this PR to my develop-branch and reject the PR here, as it messes with my GitFlow. My develop branch is a private git repo. This way I can easily release hotfixes and still have a working develop environment. Apreciated =)

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
xiconfjs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiconfjs/Gladdy-TBC#15