xiconfjs/Gladdy-TBC
1
0
Fork 0
Code Issues 36 Pull Requests 2 Packages Projects Releases 30 Wiki Activity

Glow not fadding anymore on WeakAuras when using last version of Gladdy #59

New Issue
Closed
opened 2022-08-18 21:28:05 +02:00 by mrbuds · 1 comment
mrbuds commented 2022-08-18 21:28:05 +02:00 (Migrated from github.com)
Copy Link

Hello, i'm a contributor of WeakAuras, we had a report today from a user who's glows would not fade when using WeakAuras together with last version of Gladdy

We identified the cause to be this commit https://github.com/XiconQoo/Gladdy-TBC/commit/d385692cdcb7399e794003807c61bd6f19cbdcac

I have not research exactly what is wrong in this change, but if you want to fork the lib you should change it's name to avoid breaking other addons, or submit a pull request upstream at https://github.com/Stanzilla/LibCustomGlow

Hello, i'm a contributor of WeakAuras, we had a report today from a user who's glows would not fade when using WeakAuras together with last version of Gladdy We identified the cause to be this commit <https://github.com/XiconQoo/Gladdy-TBC/commit/d385692cdcb7399e794003807c61bd6f19cbdcac> I have not research exactly what is wrong in this change, but if you want to fork the lib you should change it's name to avoid breaking other addons, or submit a pull request upstream at https://github.com/Stanzilla/LibCustomGlow
XiconQoo commented 2022-08-19 11:49:22 +02:00 (Migrated from github.com)
Copy Link

Hey @mrbuds, thanks for the reach out. A user reported that to me as well.
You are right. That commit is causing it and I reverted it. I actually didn't want to include it at all. Must have overseen it. 86fcff8ea8 reverts it with Gladdy v.2.22-Release.

Hey @mrbuds, thanks for the reach out. A user reported that to me as well. You are right. That commit is causing it and I reverted it. I actually didn't want to include it at all. Must have overseen it. 86fcff8ea83296ab47e9f3f53ff8638331f8172a reverts it with Gladdy v.2.22-Release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
xiconfjs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiconfjs/Gladdy-TBC#59
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?