xiconfjs/pyhOn
1
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 91 Wiki Activity

Fixing Support for H-WASHER 500 #5

Merged
alexandre-leites merged 3 commits from main into main 2023-03-14 18:30:30 +01:00
Conversation 2 Commits 3 Files Changed 3 +4 -2
alexandre-leites commented 2023-03-14 14:33:17 +01:00 (Migrated from github.com)
Copy Link

Hi,

My previous branch was outdated (my bad) and did not had the history methods. Therefore I encountered some issues with it and fixed with this PR. Mostly issues was about trying to set fixed values, or None types.

Please, test compatibility with your device as well.

PS: Python is not the language I know the most, therefore if there is better ways of dealing with stuff, feel free to optmize.

Hi, My previous branch was outdated (my bad) and did not had the history methods. Therefore I encountered some issues with it and fixed with this PR. Mostly issues was about trying to set fixed values, or None types. Please, test compatibility with your device as well. PS: Python is not the language I know the most, therefore if there is better ways of dealing with stuff, feel free to optmize.
Andre0512 (Migrated from github.com) approved these changes 2023-03-14 18:30:07 +01:00
Andre0512 (Migrated from github.com) left a comment
Copy Link

Hi, thank you, looks good! This will also fix #4 and #6
I will test it more careful this time and make a new release 🙂

Hi, thank you, looks good! This will also fix #4 and #6 I will test it more careful this time and make a new release :slightly_smiling_face:
Andre0512 commented 2023-03-14 18:57:11 +01:00 (Migrated from github.com)
Copy Link

All functions works without errors for me, created the new version v0.3.7

All functions works without errors for me, created the new version v0.3.7
Sign in to join this conversation.
Reviewers
No Reviewers
Andre0512
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiconfjs/pyhOn#5
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?